Fixed RC input timing jitter in IOMCU #13410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I test flew this on my Hexsoon EDU450 with CubeOrange and PPM Sum receiver and didn't notice any problems. |
|
Can this be backported ASAP ? |
|
@amilcarlucas, yes but it's also in a very sensitive area so we need to test it enough to be sure it's safe. I think we will want various devs to alpha test it and then back port it to Copter-4.0 over the next few days and then beta test it for a week or two. |
this allows disabling pulse input at runtime to lower CPU load on IOMCU when decoding via a UART
and use pulse_input_enable() to disable pulse input when not needed
and cleanup use of mutexes in RC input
this prevents a race where we continually fail to get new input
tridge
force-pushed
the
pr-sbus-jitter
branch
from
66699d0
to
7601197
Compare
|
Here are some logs from the Solo, which uses Spektrum DSM. Smooth flight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem found by @VDLJu
https://discuss.ardupilot.org/t/urgent-s-bus-input-on-4-0-1-is-stuttering-often-100-300ms-up-to-500ms/51591
The primary cause was high CPU load on IOMCU decoding input pulses unnecessarily while decoding a UART based protocol like SBUS or DSM